-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spark to 3.3.2 #198
Conversation
Awesome! I suppose an update to 3.3.2 from 3.3.1 won't cause many issues. I did change your PR to target main instead of release, as that's common for this project. Please also update gradles.properties to Spark 3.3.2 as the project always targets the latest possible Spark version by default. Same with the integration examples. I see you found a couple of versions that we forgot to update, thanks :) I'll try and run the github actions that will perform the tests in a bit :) Edit: the tests seem to work :) |
Question: should this be updated? https://github.com/Kotlin/kotlin-spark-api/blob/release/core/build.gradle.kts#L30 Looks like that logic lives in a few places in the project's build. |
Looks like the tests pass for 3.3.2, so it seems that Spark fixed the issue. I do suspect the issue is still present for 3.3.1, so it can remain like that. |
Thanks for the help! I'll probably publish 1.2.4 soon with spark 3.3.2 support and java 8 support for jupyter notebooks. |
No description provided.