From bd36681627c369aa2fdbbe00a033647e2da68b78 Mon Sep 17 00:00:00 2001
From: Jolanrensen <jolan.rensen@jetbrains.com>
Date: Thu, 12 May 2022 14:41:26 +0200
Subject: [PATCH] added dokka to jupyter module, updated readme

---
 README.md       |  4 ++++
 jupyter/pom.xml | 24 ++++++++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/README.md b/README.md
index 1481b7e8..e2a24e29 100644
--- a/README.md
+++ b/README.md
@@ -103,6 +103,10 @@ This does not start a Spark session right away, meaning you can call `withSparkS
 in whichever cell you want.
 Check out the [example](examples/src/main/kotlin/org/jetbrains/kotlinx/spark/examples/streaming/JupyterStreamingExample.ipynb).
 
+NOTE: You need `kotlin-jupyter-kernel` to be at least version 0.11.0.83 for the Kotlin Spark API to work. Also, if the 
+`%use spark` magic does not output "Spark session has been started...", and `%use spark-streaming` doesn't work at all, 
+add `%useLatestDescriptors` above it.
+
 ## Kotlin for Apache Spark features
 
 ### Creating a SparkSession in Kotlin
diff --git a/jupyter/pom.xml b/jupyter/pom.xml
index 69473488..92c2b038 100644
--- a/jupyter/pom.xml
+++ b/jupyter/pom.xml
@@ -98,6 +98,30 @@
         <testSourceDirectory>src/test/kotlin</testSourceDirectory>
         <directory>target/${scala.compat.version}</directory>
         <plugins>
+            <plugin>
+                <groupId>org.jetbrains.dokka</groupId>
+                <artifactId>dokka-maven-plugin</artifactId>
+                <version>${dokka.version}</version>
+                <configuration>
+                    <jdkVersion>8</jdkVersion>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>dokka</id>
+                        <goals>
+                            <goal>dokka</goal>
+                        </goals>
+                        <phase>pre-site</phase>
+                    </execution>
+                    <execution>
+                        <id>javadocjar</id>
+                        <goals>
+                            <goal>javadocJar</goal>
+                        </goals>
+                        <phase>pre-integration-test</phase>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>org.jetbrains.kotlin</groupId>
                 <artifactId>kotlin-maven-plugin</artifactId>