Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotInset parameter to style #406

Open
AndreiKingsley opened this issue Jul 26, 2024 · 4 comments · Fixed by #431
Open

Add plotInset parameter to style #406

AndreiKingsley opened this issue Jul 26, 2024 · 4 comments · Fixed by #431
Assignees
Labels
enhancement New feature or request lets-plot API and implementation for lets-plot

Comments

@AndreiKingsley
Copy link
Collaborator

https://nbviewer.org/github/JetBrains/lets-plot-kotlin/blob/master/docs/examples/jupyter-notebooks/f-4.7.1/theme_plot_inset.ipynb

@AndreiKingsley AndreiKingsley added enhancement New feature or request lets-plot API and implementation for lets-plot labels Jul 26, 2024
@lucas-watkins
Copy link

Hello, if this issue is still available may I please try to solve it?

@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Sep 1, 2024

Yes, you are welcome.

You need to add the inset property to the PlotCanvas custom style configuration. First you need to research its behavior in Lets-Plot and design API for it.

@lucas-watkins
Copy link

lucas-watkins commented Sep 2, 2024

I have implemented an API that is very similar to the existing one that handles margins. However, I read in CONTRIBUTING.md that all new APIs must come with documentation. Is it appropriate to add documentation in the docs folder or the examples folder in this case?

@AndreiKingsley AndreiKingsley self-assigned this Sep 3, 2024
@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Sep 3, 2024

Custom style API is still unstable, we haven't done documentation and tests yet, so you can add it without them for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lets-plot API and implementation for lets-plot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants