Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dokka to 1.9.10 #596

Closed
Jolanrensen opened this issue Feb 20, 2024 · 3 comments · Fixed by #599
Closed

Update dokka to 1.9.10 #596

Jolanrensen opened this issue Feb 20, 2024 · 3 comments · Fixed by #599
Assignees
Milestone

Comments

@Jolanrensen
Copy link
Collaborator

All dokka dependencies are stuck on v1.8.10 until korro and docProcessor update their dokka versions to 1.9.10 as well.

@Jolanrensen Jolanrensen added this to the Backlog milestone Feb 20, 2024
@Jolanrensen
Copy link
Collaborator Author

After investigation:

df dokka 1.8.20
korro 0.1.6 - dokka 1.8.20
no doc preprocessor
works

df dokka 1.8.20
korro 0.1.5 - dokka 1.8.10
no doc preprocessor
works

df dokka 1.9.10
korro 0.1.6 - dokka 1.8.20
no doc preprocessor
works

So I suspect korro is safe :) docProcessor is the culprit

@Jolanrensen Jolanrensen self-assigned this Feb 21, 2024
@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Feb 22, 2024

Continuing:

df dokka 1.8.20
no korro
doc preprocessor 0.3.2- dokka 1.8.10
works

df dokka 1.9.10
no korro
doc preprocessor 0.3.2- dokka 1.8.10
works?

df dokka 1.8.20
korro 0.1.6 - dokka 1.8.20
doc preprocessor 0.3.2- dokka 1.8.10
works

df dokka 1.9.10
korro 0.1.6 - dokka 1.8.20
doc preprocessor 0.3.2- dokka 1.8.10
works?! huh?

I don't get it. It broke last time. Some gradle cache maybe?

Edit: I did these tests with clean assemble. I'll now retry with clean build as it looks like other stuff might break with that.

@Jolanrensen
Copy link
Collaborator Author

using clean build

df dokka 1.8.10
korro 0.1.5 - dokka 1.8.10
doc processor 0.3.2 - dokka 1.8.10
works

df dokka 1.8.10
korro 0.1.6 - dokka 1.8.20
doc processor 0.3.2 - dokka 1.8.10
breaks linter :(

df dokka 1.8.20
korro 0.1.5 - dokka 1.8.10
doc processor 0.3.2 - dokka 1.8.10
works

df dokka 1.9.10
korro 0.1.5 - dokka 1.8.10
doc processor 0.3.2 - dokka 1.8.10
works

df dokka 1.9.10
korro 0.1.6 - dokka 1.8.20
doc processor 0.3.2 - dokka 1.8.10
breaks linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant