Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Column accessors functions #564

Open
Jolanrensen opened this issue Jan 19, 2024 · 0 comments
Open

Duplicate Column accessors functions #564

Jolanrensen opened this issue Jan 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request research This requires a deeper dive to gather a better understanding
Milestone

Comments

@Jolanrensen
Copy link
Collaborator

Especially in the Columns Selection DSL the library allows the user to create column accessors using either the constructors column(), columnGroup(), etc. from constructors.kt as well as col(), colGroup(), ""<>(), ""[""], etc. (now with runtime checks) from the selection DSL ColumnSelectionDsl.kt, col.kt, and colGroup.kt.

Having both is confusing. We should keep one of the two variants, or have them be exactly the same. Column shortcuts like ""<>() should be available library-wide too I think, as it's common enough.

Can be handled after #372

@Jolanrensen Jolanrensen added enhancement New feature or request invalid This issue/PR doesn't seem right research This requires a deeper dive to gather a better understanding labels Jan 19, 2024
@Jolanrensen Jolanrensen added this to the Backlog milestone Jan 19, 2024
@Jolanrensen Jolanrensen self-assigned this Jan 19, 2024
@zaleslaw zaleslaw removed the invalid This issue/PR doesn't seem right label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research This requires a deeper dive to gather a better understanding
Projects
None yet
Development

No branches or pull requests

2 participants