-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Jupyter dependencies to different module #241
Labels
Milestone
Comments
Jolanrensen
added
bug
Something isn't working
invalid
This issue/PR doesn't seem right
labels
Jan 26, 2023
It's quite painful, there are some internal things that cannot become a part of the public API, so we'd have to create 3rd module for these common internals..? For now i fixed usages of jupyter classes outside "Integration.kt", that should be enough to not break things for users outside Jupyter Notebooks. |
zaleslaw
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Apr 25, 2023
Similar to #100. Could be done with "friend/associates modules" |
Open
Fixes #700 |
Duplicated by #775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
It can be the case we now publish API calls that depend on Jupyter stuff such that a user has to implement the kotlin-jupyter-api themselves. That shouldn't be needed.
Similar to Kotlin Spark, we should put all Jupyter dependencies inside a separate module, like "dataframe-jupyter", which can then be used when users have
%use dataframe
in their notebooks.The text was updated successfully, but these errors were encountered: