Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Jupyter dependencies to different module #241

Closed
Jolanrensen opened this issue Jan 26, 2023 · 4 comments · Fixed by #769
Closed

Extract Jupyter dependencies to different module #241

Jolanrensen opened this issue Jan 26, 2023 · 4 comments · Fixed by #769
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Milestone

Comments

@Jolanrensen
Copy link
Collaborator

It can be the case we now publish API calls that depend on Jupyter stuff such that a user has to implement the kotlin-jupyter-api themselves. That shouldn't be needed.

Similar to Kotlin Spark, we should put all Jupyter dependencies inside a separate module, like "dataframe-jupyter", which can then be used when users have %use dataframe in their notebooks.

@Jolanrensen Jolanrensen added bug Something isn't working invalid This issue/PR doesn't seem right labels Jan 26, 2023
@Jolanrensen Jolanrensen added this to the 0.10.0 milestone Jan 26, 2023
@koperagen
Copy link
Collaborator

It's quite painful, there are some internal things that cannot become a part of the public API, so we'd have to create 3rd module for these common internals..? For now i fixed usages of jupyter classes outside "Integration.kt", that should be enough to not break things for users outside Jupyter Notebooks.

@koperagen koperagen removed this from the 0.10.0 milestone Apr 3, 2023
@zaleslaw zaleslaw added enhancement New feature or request and removed bug Something isn't working labels Apr 25, 2023
@zaleslaw zaleslaw added this to the Backlog milestone Apr 25, 2023
@Jolanrensen
Copy link
Collaborator Author

Jolanrensen commented Nov 17, 2023

Similar to #100.

Could be done with "friend/associates modules"

@Jolanrensen
Copy link
Collaborator Author

Fixes #700

@Jolanrensen Jolanrensen added the duplicate This issue or pull request already exists label Aug 28, 2024
@Jolanrensen
Copy link
Collaborator Author

Duplicated by #775

@Jolanrensen Jolanrensen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants