Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright notice in generated file #152

Closed
LVMVRQUXL opened this issue Oct 18, 2023 · 6 comments
Closed

Copyright notice in generated file #152

LVMVRQUXL opened this issue Oct 18, 2023 · 6 comments

Comments

@LVMVRQUXL
Copy link

I would like to add a copyright notice to the generated file published on my repository, but this change will fail the checks.
Is it possible to add comments to the generated file?
If not, then it could be an idea of enhancement for the plugin.

I'm using the version 0.12.1.

Thank you for considering this issue.

@qwwdfsad
Copy link
Member

It could be a potential feature for BCV indeed.

Could you please elaborate on the reasoning behind the copyright on the ABI dump? What exactly does it protect or what is the legal reasoning here?

@LVMVRQUXL
Copy link
Author

Sure @qwwdfsad.

Because our ABI dump can be updated by external contributors (after forking the project, adding a feature and running the apiDump task), I would like to add a copyright notice indicating that the file is governed by the project's license.
For instance, this is for the Kotools Types library.

Let me know if this is not clear, I try my best to express the intent. 😅

@fzhinkin
Copy link
Collaborator

It seems fairly simple to add an option that will include some header (and a footer, if needed) to the generated dump. However, some license notes contain dates (like Copyright 2016-2024 JetBrains s.r.o.) and it's unclear how it should be updated. Do we need to also support some primitive templating engine then? :\

@fzhinkin
Copy link
Collaborator

Also, I have to admit that I'm extremely bad in legal matters, so sorry for a silly question, but I'm just curious.
Is a text file describing project's ABI considered as a subject matter of copyright?

@LVMVRQUXL
Copy link
Author

Also, I have to admit that I'm extremely bad in legal matters, so sorry for a silly question, but I'm just curious. Is a text file describing project's ABI considered as a subject matter of copyright?

This is a good question @fzhinkin that I recently asked myself. For instance, I've decided to only put the copyright notice in the license of the Kotools Types library instead of polluting all files, including the ABI.
So I can say that this suggestion is no more a need for my projects.

@fzhinkin
Copy link
Collaborator

fzhinkin commented Apr 9, 2024

Closing the issue for now, feel free to reopen it.

@fzhinkin fzhinkin closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants