zipkin plugin #3434
Closed
zipkin plugin #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs need updating too - start here https://github.com/Kong/getkong.org/tree/docs-0.32-tracing |
gszr
reviewed
May 18, 2018
There was a problem hiding this comment.
We're missing the plugin order test - see https://github.com/Kong/kong/blob/master/spec/01-unit/014-plugins_order_spec.lua#L51
james-callahan
force-pushed
the
feat/zipkin
branch
from
c6100bd to
601b715
Compare
Added :) |
james-callahan
force-pushed
the
feat/zipkin
branch
from
601b715 to
fe837e3
Compare
|
Rebased on top of next now that #3428 is merged. |
james-callahan
force-pushed
the
feat/zipkin
branch
from
fe837e3 to
0b110e7
Compare
thibaultcha
pushed a commit
that referenced
this pull request
May 31, 2018
From #3434 Signed-off-by: Thibault Charbonnier <[email protected]>
thibaultcha
pushed a commit
that referenced
this pull request
May 31, 2018
From #3434 Signed-off-by: Thibault Charbonnier <[email protected]>
thibaultcha
pushed a commit
that referenced
this pull request
May 31, 2018
From #3434 Signed-off-by: Thibault Charbonnier <[email protected]>
thibaultcha
pushed a commit
that referenced
this pull request
May 31, 2018
From #3434 Signed-off-by: Thibault Charbonnier <[email protected]>
|
Manually merged to next! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the zipkin plugin to the Kong installation. The plugin itself is external, see https://github.com/Kong/kong-plugin-zipkin
You may want to merge this on top of #3428
Full changelog
ngx.ctx.KONG_BODY_FILTER_ENDED_ATbalancer_startIssues resolved
Fixes #1330