fix(oauth2) Issue with application/json GET requests #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GET requests can come through with a content-type of 'application/json', but will lack a body. The existing code will break on this case, by trying to parse a body that doesn't exist -- this commit adds the condition that the body must exist before we try parsing it.
|
(PS: please let me know if I can help further with getting this PR merged) |
|
We are also getting reports from clients who get 500 response on GET requests. Turns out they were passing the "Content-Type: application/json" header on GET requests. Although they should not pass this header on GET requests, returning a 500 is nevertheless a bit rude :) |
|
This has been fixed by #1915 Thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Kong maintainers,
Side note -- I've tried to be a good open source citizen, but getting a Kong development environment turned out to be too time consuming for this project, therefore I can't provide tests for this PR, besides my word that it's working for us.
Summary
We've noticed an issue in the OAuth2 plugin that would return a server error on HTTP GET requests of content-type application/json. This commit fixes it.
Full changelog
Issues resolved
GET requests can come through with a content-type of 'application/json',
but will lack a body. The existing code will break on this case, by
trying to parse a body that doesn't exist -- this commit adds the
condition that the body must exist before we try parsing it.