Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) upstreams #1541

Closed
wants to merge 28 commits into from
Closed

feat(core) upstreams #1541

wants to merge 28 commits into from

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Aug 24, 2016

Summary

Adds the upstreams feature. A work in progress...

For a basic description see #157 (comment)

An incomplete todo list;

  • implement dns resolver
  • implement balancer_by_lua
  • resolve SRV records
  • implement dns retries
  • implement balancer
  • implement balancer retry
  • implement dns resolution for cli
  • implement dns resolution for co-sockets (ldap/cassandra/postgres)
  • tests, tests, and more tests...
  • timestamp millisec precision

For now most of the existing test suite passes.

Tieske added 25 commits August 8, 2016 15:22
- added a test
- added full validation also with a wildcard
…core.balancer` which does the actual dns resolution and balancing
@Tieske Tieske added the pr/wip A work in progress PR opened to receive feedback label Aug 24, 2016
@Tieske Tieske added this to the 0.10 milestone Aug 24, 2016
@Tieske Tieske self-assigned this Aug 24, 2016
@subnetmarco
Copy link
Member

subnetmarco commented Aug 24, 2016

implement balancer_by_lua to replace proxy_pass

balancer_by_lua shouldn't replace proxy_pass, they should coexist. Maybe it's a typo, just want to make sure we are on the same page.

@Tieske
Copy link
Member Author

Tieske commented Aug 25, 2016

👍 we're on the same page

@Tieske
Copy link
Member Author

Tieske commented Aug 26, 2016

Status so far;

  • tests are now passing (except some plugins, like ldap)
  • dns resolver has been implemented (uses https://github.com/Mashape/dns.lua)
  • A and SRV records are now loadbalanced by Kong internally on a round-robin basis
  • entities upstreams and targets have been added to the datastore and management api, but are NOT functional.

Some questions;

  1. what would need to be configurable?
  2. what errors to return for failed dns lookups?

testing;
I'll try to keep this branch functional. I'll make updates in new branches, and only complete functioning updates will be merged in this branch. So at any given time this branch should be testable.

Any input, on the questions above or test results, is most welcome!

@thibaultcha thibaultcha changed the title Feature/upstreams feat(core) upstreams Sep 1, 2016
@Tieske
Copy link
Member Author

Tieske commented Oct 11, 2016

closing this in favor of #1735

@Tieske Tieske closed this Oct 11, 2016
@Tieske Tieske deleted the feature/upstreams branch December 2, 2016 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/wip A work in progress PR opened to receive feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants