Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin API and arrays #1391

Closed
subnetmarco opened this issue Jul 13, 2016 · 5 comments
Closed

Admin API and arrays #1391

subnetmarco opened this issue Jul 13, 2016 · 5 comments
Labels
task/feature Requests for new features in Kong

Comments

@subnetmarco
Copy link
Member

  • We support sending arrays with an explicit array index param[1]=v1&param[2]=v2. We should also support adding arrays without an index in the form of param[]=v1&param[]=v2.
  • Evaluate removing the comma separator in favor of arrays.
@Tieske
Copy link
Member

Tieske commented Jul 14, 2016

I don't see why we would drop the comma separated way of passing arrays. It would be a breaking change.

Instead we should advocate the array way of doing things, but not breaking the comma separated ones.

@Tieske
Copy link
Member

Tieske commented Jul 14, 2016

the underlying problem is fixed in #1399.

@subnetmarco
Copy link
Member Author

The way I see it, the comma separation is just a non-elegant solution to a problem that can be already fixed with form-encoded arrays using square brackets.

@Tieske
Copy link
Member

Tieske commented Jul 18, 2016

Hmmm... do we want to break backward compatibility because on non-elegance?

@thibaultcha
Copy link
Member

Addressed in the new Admin API - entities are now slowly migrating there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task/feature Requests for new features in Kong
Projects
None yet
Development

No branches or pull requests

4 participants