-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misdocumented breaking change in v3 #13203
Comments
@oowl , I think that you are those PR's author, could you take a look at this issue? thanks. |
@oowl and @chronolaw any updates here? Others? My organization had to roll back our upgrade from 2 -> 3 because of this breaking change. We need to make changes to the config before we can upgrade. It is our fault for configuring kong incorrectly and depending on bad behavior. However, patching this bug is a breaking change and I am just hoping to help others to hopefully catch it when reviewing the changelog. |
IMO, fixing a buggy behavior is not a breaking change. It's arguable whether we should consider fixing a bug used as a feature in a special case. @oowl votes for you and you need another vote to change the changelog. |
Agree, fixing a buggy behavior is not a breaking change. we do not add any break change log for bug fixes. |
This issue is marked as stale because it has been open for 14 days with no activity. |
Dear contributor, We are automatically closing this issue because it has not seen any activity for three weeks. Your contribution is greatly appreciated! Please have a look Sincerely, |
Is there an existing issue for this?
Kong version (
$ kong version
)3.0
Current Behavior
in 2.X if you defined
target_path
on theservice
it was ignored by the aws-lambda plugin and never prepended to the path set sent in the json payload to lambdaExpected Behavior
In 3.X if you define
target_path
on theservice
it is prepend and this is apparently expected. HOWEVER, this is a breaking change to those expecting thetarget_path
to be ignored. Can the changelog be update to reflect that #9058 and #9129 are in fact breaking changes to the 3.0 release.Steps To Reproduce
Anything else?
Please update the docs.
The text was updated successfully, but these errors were encountered: