Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mTLS Plugin Config "cert_cache_ttl" Operates in Seconds, Not Milliseconds #7732

Open
2 tasks done
deckong opened this issue Aug 7, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels

Comments

@deckong
Copy link

deckong commented Aug 7, 2024

Where is the problem?

https://docs.konghq.com/hub/kong-inc/mtls-auth/configuration/#config-cert_cache_ttl

What happened?

The context for this configuration mentions it operates in milliseconds but it in fact operates in seconds.

The other plugin config "cache_ttl" appears to be documented correctly.

What did you expect to happen?

The language should change to reflect "seconds", not "milliseconds".

Code of Conduct and Community Expectations

  • I agree to follow this project's Code of Conduct
  • I agree to abide by the Community Expectations
@cloudjumpercat
Copy link
Contributor

Thanks for the feedback @deckong ! I opened a PR here that fixes this: https://github.com/Kong/kong-ee/pull/10378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants