Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulkan commandbuffer from Tensor #42

Closed
axsaucedo opened this issue Sep 5, 2020 · 0 comments
Closed

Remove vulkan commandbuffer from Tensor #42

axsaucedo opened this issue Sep 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@axsaucedo
Copy link
Member

Currently a tensor owns a comand buffer vulkan object and performs the recordCopy as a command. Initially this was designed as the idea was to avoid exposing the buffer from the tensor itself. The command buffer is also used to create the barrier. However in the case of the barrier, it's possible to just return the barrier itself, and for the case of the recordCopy, it would be possible to just pass the commandbuffer as parameter as opposed to having it as an owned component. This is also important as a tensor shoudl not be bound to a single command buffer.

@axsaucedo axsaucedo added the enhancement New feature or request label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant