Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic happens with index out of bounds in utxo_common::tx_details_by_hash #1906

Closed
shamardy opened this issue Jul 10, 2023 · 3 comments · Fixed by #1915
Closed

Panic happens with index out of bounds in utxo_common::tx_details_by_hash #1906

shamardy opened this issue Jul 10, 2023 · 3 comments · Fixed by #1915
Assignees
Labels
bug Something isn't working P1

Comments

@shamardy
Copy link
Collaborator

This issue is transferred from komodo-wallet-desktop to here. Original issue https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2317.

Error: 29 17:26:27, common:500] panicked at 'index out of bounds: the len is 2 but the index is 2', mm2src\coins\utxo\utxo_common.rs:3119:29

The above error is probably related to an incorrect deserialization of a transaction, it would be good to add more logs to catch more info about such cases in the future. It would also be good to add a length check here

let prev_tx_value = prev_tx.outputs[input.previous_output.index as usize].value;
to prevent this from happening in the future while logging the error instead of panicking.

@mariocynicys
Copy link
Collaborator

Looks like #1915 fixes the panic issue. The komodo desktop issue was seemingly purged.
Should we close this issue then? (unless we can retrieve the komodo desktop issue).

@cipig
Copy link
Member

cipig commented Dec 2, 2024

all issues from komodo desktop are "lost", they were all closed when repo was renamed/moved

@mariocynicys
Copy link
Collaborator

Will close this for now.
The potential incorrect serialization might show up later and then we can file an issue for it with the available info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
3 participants