Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for the confirmation of the approval transaction for EVM tokens before sending the swap payment #1689

Closed
shamardy opened this issue Mar 2, 2023 · 0 comments
Closed

Wait for the confirmation of the approval transaction for EVM tokens before sending the swap payment #1689

shamardy opened this issue Mar 2, 2023 · 0 comments
Assignees
@shamardy
Labels
bug Something isn't working

Comments

@shamardy
Copy link
Collaborator

shamardy commented Mar 2, 2023

The swap transaction fails if sent without the approval transaction being confirmed first if approval was needed
https://github.com/KomodoPlatform/atomicDEX-API/blob/f32cb177b37bb99aa08b62728bf93424fa5ca22f/mm2src/coins/eth.rs#L2942-L2950
@shamardy shamardy self-assigned this Mar 2, 2023
@shamardy shamardy added the bug Something isn't working label Mar 2, 2023
@shamardy shamardy mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamardy shamardy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shamardy