-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise GUI asset files #875
base: master
Are you sure you want to change the base?
Conversation
1 - links similar to the below is not used in mm2 Lines 209 to 212 in d6b78c6
2 - Line 193 in d6b78c6
3 - Any UTXO coin with decimals = 8 like the below the decimals field can be removed since it's set as 8 by default in mm2. This is for coins with Lines 7065 to 7084 in d6b78c6
4 - Signature version defaults to base when there is no fork_id in config similar to the below, so it can be removed in similar cases, also be careful with this. Lines 14380 to 14405 in d6b78c6
5 - Any utxo coin with Line 3402 in d6b78c6
6 - Any utxo coin that has Line 10391 in d6b78c6
7 - Any 8 - Any utxo with I couldn't go through the whole coins file of course but the above is a list of what I found :) |
Closes: #872
Initial implementation to review for feasibility of solution.
Reduction methods:
coins_config
which are already present incoins
file (deduplication)coins_config
(swap_contract, fallback swap_contract, parent_coin) intocoin_type_map.json
. These values are accessible via thetype
value incoins_config
.coins
file which are not present incoins_config
file (e.g. where rejected due to failing electrums or lack of data etc)Earlier, the script was modified to output TCP / SSL / WSS only variants of
coins_config
. These should be used where appropriate to further filter out data not relevant to usage. See #821 for more info.The above reductions are applied to each variant after they have been re-calculated. Originals have been retained in case of external / legacy usage to avoid breaking backwards compatibility.
@CharlVS please advise if the newer reduced output is usable in flutter apps. There should be minimal changes to code required beyond updating filenames and sourcing some info from either
coin_type_map.json
orcoins_*_minified
instead ofcoins_config_*.json
@shamardy are there any data keys within the
coins
file which can be safely removed (or moved to a supplemental file) without upsetting mm2?