Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove electrum limit, sort by url #1153

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Remove electrum limit, sort by url #1153

merged 4 commits into from
Oct 30, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 18, 2024

Prior to this PR, coins with more than 3 electrums would have this sliced down to just 3 active. In light of KomodoPlatform/komodo-defi-framework#1966 this limit is better handled in the kdf/app layer.

Additionally, the nodes, rpc_urls and electrums values for coins in the coins_config.json output are sorted alphabetically (by the url key) - this will help avoid "diff inflation" from new PRs where only the sequence of spv server objects has changed.

@smk762 smk762 requested review from gcharang, cipig and CharlVS October 18, 2024 10:49
@mariocynicys
Copy link

bear in mind though that GUIs would need to include max_connected: 3 in the electrum enable request to achieve the same setup removed here. max_connected is assumed infinity by default.

@cipig
Copy link
Member

cipig commented Oct 18, 2024

Problem is this from utils/coins_config_tcp.json

        "electrum": [
            {   
                "url": "electrum1.cipig.net:10001",
                "contact": [
                    {
                        "email": "[email protected]"
                    },
                    {
                        "discord": "cipi#4502"
                    }
                ],
                "protocol": "TCP"
            },
            {
                "url": "electrum1.cipig.net:20001",
                "protocol": "SSL",
                "contact": [
                    {
                        "email": "[email protected]"
                    },
                    {
                        "discord": "cipi#4502"
                    }
                ]
            },
            {
                "url": "electrum1.cipig.net:30001",
                "protocol": "WSS",
                "contact": [
                    {
                        "email": "[email protected]"
                    },
                    {
                        "discord": "cipi#4502"
                    }
                ]
            },
            {
                "url": "electrum2.cipig.net:10001",
                "contact": [
                    {
                        "email": "[email protected]"
                    },
                    {
                        "discord": "cipi#4502"
                    }
                ],
                "protocol": "TCP"
            },

so mm2 will connect to electrum1 twice, with TCP and with SSL
can we make it so that one electrum server (like electrum1.cipig.net) is present only once?

@smk762 smk762 merged commit 1b2e607 into master Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants