Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

Merged
merged 55 commits into from
Mar 23, 2023
Merged

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

merged 55 commits into from
Mar 23, 2023

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Mar 7, 2023 •
edited
Loading

The PR provides:

  • Less compilation time
  • Less size on binary builds
  • Disables solana completely if the feature isn't provided in build(which is disabled by default)
  • Fixes some of the advisory IDs
  • Tests are seperated to multiple steps which provides async execution on CI
  • All pipelines will be executed in async way without blocking each other(except container building/pushing, ssh connections, etc)
  • Updated Jemalloc flags
  • CI now checks lint rules for all targets
  • Fixed all the lint warnings on wasm and tests
  • More platform support on build targets from CI
  • CI migration from Azure to Github Actions

Don't forget to squash the commits when merging this.

Resolves #1663

@onur-ozkan onur-ozkan changed the title [wip] sec fixes, build-time optimizations, dependency optimizations, etc [wip] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 8, 2023
@onur-ozkan onur-ozkan force-pushed the dep-work branch 2 times, most recently from 55358c5 to b08ecc1 Compare March 8, 2023 13:47
@onur-ozkan onur-ozkan force-pushed the dep-work branch 6 times, most recently from 566b91e to e898587 Compare March 10, 2023 15:50
@ca333 ca333 requested a review from DeckerSU March 16, 2023 08:16
@onur-ozkan onur-ozkan changed the title [wip] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc [blocked] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 16, 2023
@onur-ozkan onur-ozkan changed the title [blocked] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 16, 2023
@onur-ozkan onur-ozkan added the blocked requires additional attention label Mar 16, 2023
ca333
ca333 previously approved these changes Mar 20, 2023
View reviewed changes
Copy link

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sec code reviewed @ 78d3307

mm2src/coins/Cargo.toml
byteorder = "1.3"
bytes = "0.4"
cfg-if = "1.0"
chain = { path = "../mm2_bitcoin/chain" }
common = { path = "../common" }
cosmrs = { version = "0.7", default-features = false }
crossbeam = "0.7"
crossbeam = "0.8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @DeckerSU

mm2src/coins/Cargo.toml
@@ -144,5 +151,5 @@ winapi = "0.3"
mm2_test_helpers = { path = "../mm2_test_helpers" }

[build-dependencies]
prost-build = { version = "0.10.3", default-features = false }
prost-build = { version = "0.10.4", default-features = false }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeckerSU

mm2src/coins/Cargo.toml
Comment on lines +105 to +106
bincode = { version = "1.3.3", default-features = false, optional = true }
ed25519-dalek-bip32 = { version = "0.2.0", default-features = false, optional = true }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @DeckerSU

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi we already had these. I suggest to check Cargo.lock diff for more clear information about dependency changes

@onur-ozkan
test
6c706ce 
Signed-off-by: ozkanonur <[email protected]>
@onur-ozkan onur-ozkan force-pushed the dep-work branch 3 times, most recently from d9fc126 to 6c706ce Compare March 20, 2023 16:51
@onur-ozkan onur-ozkan force-pushed the dep-work branch 2 times, most recently from 5938550 to 5b99b98 Compare March 20, 2023 22:01
@onur-ozkan onur-ozkan removed the blocked requires additional attention label Mar 20, 2023
shamardy
shamardy previously approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the amazing work 🚀 !
Only one non-blocker related to change logs :)

CHANGELOG.md Outdated Show resolved Hide resolved
@ca333 ca333 merged commit ba26cb6 into dev Mar 23, 2023
@shamardy shamardy deleted the dep-work branch March 23, 2023 23:15
@ca333 ca333 mentioned this pull request Mar 27, 2023
Merged
@onur-ozkan onur-ozkan mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy left review comments

@ca333 ca333 ca333 left review comments

@DeckerSU DeckerSU Awaiting requested review from DeckerSU

Assignees
No one assigned
Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onur-ozkan @ca333 @shamardy