Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zcoin): resume previous sync if sync_params are not provided #1967

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix(zcoin): resume previous sync if sync_params are not provided #1967

merged 3 commits into from
Sep 18, 2023

Conversation

borngraced
Copy link
Member

No description provided.

@borngraced
enhance sync
f88576f 
Signed-off-by: borngraced <[email protected]>
@borngraced borngraced requested a review from shamardy September 11, 2023 15:32
@borngraced borngraced self-assigned this Sep 11, 2023
@borngraced
fix wasm linting
5f32cf5 
Signed-off-by: borngraced <[email protected]>
shamardy
shamardy reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review iteration! I believe there are more room for improvements/refactors of the code to make it more readable, this will make it easy to review and detect any bugs similar to the one we faced here.

mm2src/coins/z_coin/z_rpc.rs Outdated Show resolved Hide resolved
mm2src/coins/z_coin/z_rpc.rs Outdated Show resolved Hide resolved
mm2src/coins/z_coin/storage/walletdb/mod.rs Outdated Show resolved Hide resolved
@borngraced
fix review notes
80b6c3c 
Signed-off-by: borngraced <[email protected]>
@shamardy shamardy changed the title fix(zcoin): default sync fix/enhancement fix(zcoin): resume previous sync if sync_params are not provided Sep 13, 2023
@shamardy
Copy link
Collaborator

@borngraced can you please provide the changes done in this PR so that it can be documented by @KomodoPlatform/qa?

@shamardy shamardy requested review from cipig and smk762 September 13, 2023 09:46
@borngraced
Copy link
Member Author

borngraced commented Sep 13, 2023 •
edited
Loading

@KomodoPlatform/qa , the only change in this PR is synchronization uses 2 days as sync starting point only when sync_params is not provided and no previously sync state.

@shamardy shamardy merged commit b34c91a into dev Sep 18, 2023
28 of 33 checks passed
@shamardy shamardy deleted the zcoin-sync-fix branch September 18, 2023 08:20
@cipig cipig mentioned this pull request Sep 19, 2023
Closed
@smk762 smk762 mentioned this pull request Sep 21, 2023
Merged
@shamardy shamardy mentioned this pull request Dec 15, 2023
Merged
@smk762 smk762 removed the docs label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@smk762 smk762 smk762 approved these changes

@cipig cipig cipig approved these changes

Assignees

@borngraced borngraced

Labels
QA under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@borngraced @shamardy @cipig @smk762