Skip to content
This repository has been archived by the owner on Nov 17, 2018. It is now read-only.

Upgrade to 1.3.0 - error when compiling #31

Closed
mTrax- opened this issue Aug 22, 2018 · 5 comments
Closed

Upgrade to 1.3.0 - error when compiling #31

mTrax- opened this issue Aug 22, 2018 · 5 comments

Comments

@mTrax-
Copy link

mTrax- commented Aug 22, 2018

Hi,

After upgrading to 1.3.0, I have this error when compiling.
Any clue ?

Cheers,
G.

Java.lang.NullPointerException
	at nz.co.jammehcow.jenkinsdiscord.WebhookPublisher.perform(WebhookPublisher.java:94)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
	at hudson.model.Build$BuildExecution.cleanUp(Build.java:196)
	at hudson.model.Run.execute(Run.java:1862)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Build step 'Discord Notifier' marked build as failure
@KocproZ
Copy link
Owner

KocproZ commented Aug 24, 2018

I couldn't reproduce this issue.
Can you go into webhook configuraton and set/change the Title and then try again?

@aveao
Copy link
Contributor

aveao commented Sep 9, 2018

Can repro, testing with title.

@aveao
Copy link
Contributor

aveao commented Sep 9, 2018

Works, but why is this a problem that's happening now and why didn't it happen before? It should really be fixed.

@KocproZ
Copy link
Owner

KocproZ commented Sep 9, 2018

When adding functionality to this plugin new variables were added to WebhookPublisher. While they are set in a constructor, Jenkins calls the constructor only when changes to project's configuration are made. It means that when plugin is updated, but project's configuration isn't changed, the new variables are null when they shouldn't.

Changing the project configuration is a workaround, because it forces Jenkins to call the WebhookPublisher constructor.

@aveao
Copy link
Contributor

aveao commented Sep 13, 2018

Wouldn't it make sense to have default values so that the plugin doesn't die when values are inputted as null?

@KocproZ KocproZ closed this as completed Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants