Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP 5.6 related ToDo #380

Closed
AdrianHL opened this issue Dec 16, 2019 · 0 comments
Closed

Remove PHP 5.6 related ToDo #380

AdrianHL opened this issue Dec 16, 2019 · 0 comments

Comments

@AdrianHL
Copy link
Contributor

Just found that

snappy/src/Knp/Snappy/AbstractGenerator.php

Line 179 in 162633e

} catch (\Exception $e) { // @TODO: should be replaced by \Throwable when support for php5.6 is dropped
contains a ToDo that is not longer needed as Exception does implement Throwable interface in PHP7 (see https://www.php.net/manual/en/class.exception.php).
@AdrianHL AdrianHL mentioned this issue Dec 16, 2019
Merged
@AdrianHL AdrianHL changed the title Remove ToDo Remove PHP 5.6 related ToDo Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexpozzi @AdrianHL