rawQueryString seems to be a string instead of bytes literals

[vincentsarago]

👋 @ERM, first let me thank you for this great awesome library, as the author of another proxy for aws lambda I know this can be a 🕳️ sometimes.

I'm currently working on https://github.com/developmentseed/titiler which is a FastAPI based tile server. When deploying the lambda function using mangum and the new api gateway HTTP endpoint, most of my endpoints works except for the ones where I call request.url.scheme
e.g: https://github.com/developmentseed/titiler/blob/master/titiler/api/api_v1/endpoints/metadata.py#L59

and I get AttributeError: 'str' object has no attribute 'decode'

Logs

File "/tmp/pip-unpacked-wheel-a0vaawkp/titiler/api/api_v1/endpoints/metadata.py", line 59, in tilejson
File "/tmp/pip-unpacked-wheel-xa0z_c8l/starlette/requests.py", line 56, in url
File "/tmp/pip-unpacked-wheel-xa0z_c8l/starlette/datastructures.py", line 45, in __init__
AttributeError: 'str' object has no attribute 'decode'

So looking at my cloudwatch logs I can deduce:

1. in https://github.com/encode/starlette/blob/97257515f8806b8cc519d9850ecadd783b3008f9/starlette/datastructures.py#L45 starlette expect the query_string to be a byte literal

2. in https://github.com/erm/mangum/blob/4fbf1b0d7622c19385a549eddfb603399a125bbb/mangum/adapter.py#L100-L106

it seems that Mangum is getting the rawQueryString for the event, and in my case I think this would be a string instead of a byte literal.

I'll work on adding logging and test in my app to confirm this, but I wanted to share this to see if I was making sense ;-)

Thanks

[jordaneremieff]

@vincentsarago thanks for the detailed description of the issue. :)

I had a look, a bytes string is being suppled for the rawQueryString in the tests, but this is incorrect. I'm working on a pre-release currently and will address this as part of those changes.

I'll update this issue when the changes are in.

[jordaneremieff]

These changes are now in master, dc14a00#diff-12d2884e46108e48b62f0482aa6988d3R104. I'll see about a pre-release later tonight or tomorrow (still want to do some more testing of the latest batch of changes before pushing 0.9.0).

[jordaneremieff]

Actually I ended up just pushing the 0.9.0 release (includes this change). Please follow-up if you run into any further issues.

[vincentsarago]

thanks a lot @ERM I will test it right away :-)

[vincentsarago]

Everything works now 😄 🎉
thanks so much