Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask Abersheeran review 👀 #2

Open
Kludex opened this issue Jan 2, 2024 · 2 comments
Open

Ask Abersheeran review 👀 #2

Kludex opened this issue Jan 2, 2024 · 2 comments

Comments

@Kludex
Copy link
Owner

Kludex commented Jan 2, 2024

Hey @abersheeran, if you have time, can you check the FileResponse that I've implemented here?

I'm not sure if we should make this go to Starlette, or just go with this separate package.

@abersheeran
Copy link

I looked at the code and it seems fine. I think it would be better to put it in Starlette. This is a stable HTTP specification. Once written, it does not require special effort to maintain.

@Kludex
Copy link
Owner Author

Kludex commented Jan 8, 2024

Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants