-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reversing extruder direction and more #5210
Conversation
Hi, @KevinOConnor |
TEST: SYNC_EXTRUDER_MOTION1/ 4/ 6/
TEST: SET_EXTRUDER_ROTATION_DISTANCE1 / 2 / When I change the Is there anything else I need to test? |
Thanks.
This was the intended behavior. The SET_EXTRUDER_ROTATION_DISTANCE and SYNC_EXTRUDER_MOTION work on the extruder stepper motor specified in the command.
This was the intended behavior. Each extruder object has a "stepper motor" and a "motion queue". The SYNC_EXTRUDER_MOTION command alters the behavior of the stepper motor, while ACTIVATE_EXTRUDER command activates a particular motion queue. So, if you have a motion queue with no steppers associated with it, then no movement will be observed.
This info can be exported if desired.
I'm not sure what your hardware is, so it's hard for me to say. If you've got a single extruder stepper motor controlling two filament drives, then I'd guess you would define only one -Kevin |
Thanks,
Yes, now I use the definition the Video of how SWITCHING EXTRUDER works: https://youtu.be/BOaIMiyzaks |
I don't understand the issue. There isn't a That said, this PR just adds the ability to reverse the extruder stepper motor at runtime via -Kevin |
Yes this PR is not about my configuration ..... Forget about my problem ... |
Okay, thanks for testing and providing feedback. I don't own one of these "multi-filament extruders", so I don't really know what is useful or not useful. I added support for reversing the direction of the extruder motor at runtime because I thought it may be useful. If it isn't useful though, I'll rethink that strategy. Thanks again, |
I'm very happy to help with testing. Reversing the direction of the extruder motor at runtime is definitely a useful thing as well as synchronizing the extruder. I can imagine the same for any stepper (X, Y, Z etc). |
cc277ab
to
83deccd
Compare
Support altering the extruder distance using the higher-level rotation_distance. This is in preparation for removal of the SET_EXTRUDER_STEP_DISTANCE command. Signed-off-by: Kevin O'Connor <[email protected]>
… movement Extend SET_EXTRUDER_ROTATION_DISTANCE to support reversing the direction of extruder movement. Signed-off-by: Kevin O'Connor <[email protected]>
This command is a rename of SYNC_STEPPER_TO_EXTRUDER. This change is in preparation for the removal of SYNC_STEPPER_TO_EXTRUDER. Signed-off-by: Kevin O'Connor <[email protected]>
…tion Deprecate SET_EXTRUDER_STEP_DISTANCE and SYNC_STEPPER_TO_EXTRUDER. Recommend using SET_EXTRUDER_ROTATION_DISTANCE and SYNC_EXTRUDER_MOTION. Deprecate the extruder "shared_heater" option and reocmmend using extruder_stepper config sections to obtain the same functionality. Signed-off-by: Kevin O'Connor <[email protected]>
83deccd
to
2e17519
Compare
Okay, thanks. I committed this PR. -Kevin |
This PR adds a new
SET_EXTRUDER_ROTATION_DISTANCE
command. It supports specifying a "negative rotation distance" which will have the effect of reversing the extruder stepper direction. This may be useful for printers with a single extruder motor that can switch between two hotends via a servo.I do not have a good way to test this PR. Feedback would be appreciated.
This PR is a continuation of PR #5143. This PR also deprecates the
shared_heater
config option, deprecates theSYNC_STEPPER_TO_EXTRUDER
command, and deprecates theSET_EXTRUDER_STEP_DISTANCE
command. There are new replacements for all of these features.This PR was built on top of PR #5209.
@DrumClock , @Tircown - FYI.
-Kevin