-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync_extruder_steppers #4489
Conversation
Thanks. As high-level feedback, though, I think this change should wait until we've reworked the code so that the existing Also, the help text on the new command mentions that the command syncs "heaters and stepper", but that doesn't seem to be the case? -Kevin |
Thank you for the comment. The mention of heating is an oversight from the original version (PR 4445). I do understand that it's not right to add and then remove a G-code command. Duplication and mirroring modes require the extruder and extruder1 to make the same movements. Unless to declare dummy pins in extruder1 and an extruder_stepper section with the real pins and use the Have you defined a schedule for the extruder.py rework? Can I help on some points? |
Just to be clear, I'm not suggesting that one define an
I haven't looked at it in sufficient detail. I'll try to take a closer look at it. -Kevin |
Thank you for the comment. |
I do think it would be useful to merge this support into Klipper. If there is still interest in working on this then please update it to the latest code and I will prioritize a review of this work. Thanks, |
Add ability to synchronize extruder steppers.
2477982
to
1bae660
Compare
An oversight from a previous version. The heater is not used anymore.
Thank you. The PR is ready to be reviewed and hopefully merged. |
Thanks. At a high-level, I think it makes sense to add this support. However, I think it would be preferable to refactor the existing SYNC_STEPPER_TO_EXTRUDER than to introduce a new SYNC_EXTRUDER_STEPPERS command. I have attempted to do this in PR #5143 . Unfortunately, I don't have a good way to test that PR. Would you be able to review that PR and see if it meets the requirements here? -Kevin |
Thanks. I think I can close this PR since #5143 seems to work perfectly now for what we need in idex modes. |
Add the possibility to synchronize multiple extruder steppers.
Typical usage is to mimic extruder with extruder1 on an IDEX printer printing in duplication or mirrored mode.
Related to PR #4464, replace #4445.
Signed-off-by: Fabrice GALLET [email protected]