Adding support for persisting RawRepresentable #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 30.05% 29.79% -0.27%
==========================================
Files 6 7 +1
Lines 1364 1376 +12
==========================================
Hits 410 410
- Misses 954 966 +12
Continue to review full report at Codecov.
|
|
Hey @jeremyquinn, could you rebase your commits on top of master? because the |
|
Hi Enrique
I think the whole thing needs rejecting.
Soon after making the commit and the PR, I realised I had an error here.
Not sure the code is working as planned.
I have to head off soon this evening and am starting a new project tomorrow, so it may take a day or two before I can get back to this.
Sincerest apologies.
regards Jeremy
… On 5 Jun 2018, at 17:08, Enrique Lacal ***@***.***> wrote:
Hey @jeremyquinn, could you rebase your commits on top of master? because the Date commit is already in master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I made a mistake here testing this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, here is basic support for database encoding/decoding of
RawRepresentableenum values.Currently only two types are supported:
IntandString.While I beleive these are the most commonly used ones, it should be possible to support any type that is
Codable.