-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace BlueRSA, BlueECC and BlueCrypto with Apple's Swift Crypto #118
base: master
Are you sure you want to change the base?
Conversation
this currently drops support for RSA
run using `swift package plugin --allow-writing-to-package-directory swiftformat`
- add testSignAndVerifyECDSA256 - rewrite testJWTEncoder, testJWTDecoder and testJWTCoderCycle to use ECDSA instead of RSA - re-enable testJWTEncoder, testJWTDecoder and testJWTCoderCycle
Kudos, SonarCloud Quality Gate passed! |
Thanks for this PR. Do you know if RSA has been added to Swift Crypto yet? |
- RSA with either public key or private key is supported - RSA with certificate is not supported
Quality Gate passedIssues Measures |
@dannys42 It seems like Swift Crypto supports RSA via the |
@wassup- Could you review & accept the CLA so this is no longer blocked? I personally need this to get compatibility with visionOS. Thank you for the hard work! |
@Jeehut I have signed the CLA, however I'm afraid this repository is kind of abandoned. Here's to hoping this will be reviewed and possibly even merged soon 🤞 |
Since I was running into the same issue as #117 , I decided to actually switch over to Apple's Swift Crypto.
For me this fixes the build issues. Make sure to leave a comment if it doesn't for you!
The most notable changes:
RSA support is missing because -if I'm not mistaken- RSA is not currently part of Swift Crypto.
Any suggestions on how to add support RSA are welcome!