Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address build warnings on the 'operator' member variable of structs #63

Open
LowAmmo opened this issue Sep 30, 2022 · 3 comments
Open

Comments

@LowAmmo
Copy link
Contributor

LowAmmo commented Sep 30, 2022

Just seeing a build warning when targetting a higher iOS version -

 private let `operator`: Operator = .lowerThan

Immutable property will not be decoded because it is declared with an initial value which cannot be overwritten

I can work on a PR to address...and would appreciate a follow up cocoapods release so we would be able to consume the updated code.

-Thanks!

@LowAmmo
Copy link
Contributor Author

LowAmmo commented Sep 30, 2022

Nevermind...looks like this has already been addressed with v. 2.0.1.

We consume this through SwiftJWT, which is still referencing 1.2 in the current cocoapod version.

Will work on a PR to update the cocoapod version of SwiftJWT.

@LowAmmo
Copy link
Contributor Author

LowAmmo commented Sep 30, 2022

Somewhat related - while I was working to resolve the warning (that isn't a problem anymore in the latest version), I saw a new warning in the test file.

Will go ahead and submit a PR to address that warning.

@LowAmmo
Copy link
Contributor Author

LowAmmo commented Sep 30, 2022

 guard let myQueryData: Data = try? QueryEncoder().encode(query) else {

Immutable value 'myQueryData' was never used; consider replacing with '_' or removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant