Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if printer no longer on network remove from map #70

Open
jessfraz opened this issue Aug 14, 2024 · 1 comment
Open

if printer no longer on network remove from map #70

jessfraz opened this issue Aug 14, 2024 · 1 comment

Comments

@jessfraz
Copy link
Contributor

No description provided.

@paultag
Copy link
Collaborator

paultag commented Aug 23, 2024

during the great refactoring I made two changes to deal with this:

  1. Discovery will retain a handle to the pool of connected machines which it can modify -- removing and adding machines (access wrapped around a Mutex, so you won't kill an in-progress build)

  2. I added a new healthcheck endpoint each Control traited object implements, so we can differentiate between "The API threw an error" and "The printer went away" without solely relying on timeout. For static (non-discoverable) machines (currently just moonraker?) that can fail, it may need a few small tweaks (retry all un-connected but configured machines on a clock, connect, run healthcheck, if good add, if bad, abort).

I'd love to add some logic where, after an Error is dropped from a Machine, we'll re-check health before moving on so that we can drop unhealthy machines that we can't talk to anymore or something

(which is to say, thinking about this one!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants