Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A function to overwrite Popup class #124

Merged
merged 1 commit into from
Apr 14, 2017
Merged

A function to overwrite Popup class #124

merged 1 commit into from
Apr 14, 2017

Conversation

thomasconner
Copy link
Contributor

Description

This PR adds a function to the User class to overwrite the Popup class used for Mobile Identity Connect. Right now, a build tool such as Webpack is used to replace the popup class used at the time a bundle is generated. This PR would eliminate the need for this.

Changes

  • Add usePopupClass() function to the User class.

@codecov-io
Copy link

Codecov Report

Merging #124 into master will decrease coverage by 0.8%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   82.06%   81.25%   -0.81%     
==========================================
  Files          78       78              
  Lines        6533     6503      -30     
  Branches     1054     1049       -5     
==========================================
- Hits         5361     5284      -77     
- Misses       1172     1219      +47
Impacted Files Coverage Δ
src/entity/src/user.js 56.58% <33.33%> (-0.22%) ⬇️
src/datastore/src/sync.js 82.33% <0%> (-6.38%) ⬇️
src/datastore/src/cachestore.js 59.05% <0%> (-4.02%) ⬇️
src/request/src/cache.js 96.36% <0%> (-2.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6646789...71ef50d. Read the comment docs.

Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasconner thomasconner merged commit a6b14eb into master Apr 14, 2017
@thomasconner thomasconner deleted the popup branch April 14, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants