Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinto-admin package's not properly installed in docker image #2322

Closed
kaloneh opened this issue Oct 30, 2019 · 2 comments · Fixed by #2329
Closed

kinto-admin package's not properly installed in docker image #2322

kaloneh opened this issue Oct 30, 2019 · 2 comments · Fixed by #2329

Comments

@kaloneh
Copy link
Contributor

kaloneh commented Oct 30, 2019

Following errors are reported during composing images by docker-compose

> [email protected] build /app/kinto/plugins/admin
> react-scripts build

Creating an optimized production build...
Failed to compile.

./node_modules/kinto-admin/lib/index.js
Cannot find module: 'react-redux'. Make sure this package is installed.

You can install this package by running: npm install react-redux.


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] build: `react-scripts build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-10-30T13_29_25_294Z-debug.log

Usage:
  pip3 install [options] <requirement specifier> [package-index-options] ...
  pip3 install [options] -r <requirements file> [package-index-options] ...
  pip3 install [options] [-e] <vcs project url> ...
  pip3 install [options] [-e] <local project path> ...
  pip3 install [options] <archive url/path> ...

It seems this issue connects to package.json in kinto-admin package and usage of the package in the application!

@leplatrem
Copy link
Contributor

You are right, there are issues, we have 3 PRs that fail with the same kind of error.

Is it related to #2279 ?

@kaloneh
Copy link
Contributor Author

kaloneh commented Nov 1, 2019

There are two different packages including react-redux and redux. Former depends on latter while the latter has been declared in package.json and the application looking for a proper instance of the react-redux that's been missed. You can explore node_module and find out why this error comes up!
I think it should have been saved as dev dependency by npm install --save-dev react-redux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants