Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory permission backend implementation of remove_principal() is wrong #1955

Closed
glasserc opened this issue Jan 3, 2019 · 0 comments
Closed

Comments

@glasserc
Copy link
Contributor

glasserc commented Jan 3, 2019

According to the PermissionBase docstring, remove_principal is supposed to Remove a principal from every user. In other words, remove_principal(principal) is equivalent to remove_user_principal(user_id, principal) for user_id in all_possible_user_ids. However, the current implementation stores all permissions of all kinds in one hash table, and removes the principal from permissions of non-user things as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant