Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB logging is enabled by default -- battery life impact? #98

Closed
elipsitz opened this issue Jan 31, 2023 · 1 comment · Fixed by #101
Closed

USB logging is enabled by default -- battery life impact? #98

elipsitz opened this issue Jan 31, 2023 · 1 comment · Fixed by #101

Comments

@elipsitz
Copy link

It appears that USB logging is enabled by default:

https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/V2.0/config/boards/arm/adv360/adv360_left_defconfig#L61-L63
https://github.com/KinesisCorporation/Adv360-Pro-ZMK/blob/V2.0/config/boards/arm/adv360/adv360_right_defconfig#L59-L61

The ZMK docs warn against this, due to an impact on power consumption: https://zmk.dev/docs/development/usb-logging

Enabling logging increases the power usage of your keyboard, and can have a non-trivial impact to your time on battery. It is recommended to only enable logging when needed, and not leaving it on by default.

Was this left enabled intentionally? Should it be turned off by default to help conserve battery? I've noticed that my keyboard's battery lasts for less time than advertised, and I wonder if this could be partly responsible.

@ReFil
Copy link
Collaborator

ReFil commented Feb 2, 2023

USB logging was left enabled to simplify customer service, allowing for logs to be taken off boards without recompiling firmware. whilst it does have some impact on the battery the lighting features are orders of magnitude more power consuming when enabled, if you're having battery life concerns ensure all lighting is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants