-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod Morphs without keep_mods applies modifier to the first press of the modded binding #83
Comments
Will investigate, thanks for bringing to my attention |
I have a similar problem with this mod morph in my config:
Normal press ( |
The base zmk branch has just been updated with the latest changes from zmk main, are you ok to rebuild fw and try again? |
I just rerun the workflow file and flashed both sides (had to do the reset first) - the issue is still present. |
I will test hopefully later today tomorrow and let you know (I'm OP). |
It still doesn't work for me. I built locally with Docker and was careful to --no-cache. |
did the build process you used rerun |
So I tested using simple buttons like |
It's certainly possible you have a bad key switch. Which switch are we talking about? Before we issue an RMA though we'd want you to install a copy of the factory default firmware which you can download here: |
Tried that. The settings have been applied, but the Key does not output |
Roger that. Please submit a ticket and we'll issue an RMA and then replace the switch under warranty. Sorry for the inconvenience. https://kinesis-ergo.com/support/contact-a-technician/ |
I have a similar issue if not exactly the same. Please see zmkfirmware/zmk/issues/1685. Seems like it is specific to Kinesis Pro and it really bugs me. |
@zemackdaddy I noticed that in my case this happens whem karabiner elements is processing keyboard events (even if nothing to do on karabiner side). Once I disabled karabiner processing of the Kinesis keyboard this got resolve. |
@ReFil the problem occurs on Mac with and without Karabiner and also on Windows. |
That fix is merged into the branch the config repo builds from. I'm not sure why the fix isn't working on this application |
This is now working for me. |
Here is a branch made directly from the v2.0 repo here.
In the most recent commit, you can see I added this behavior:
and bound it to the 4th key (3) in the top left of the left half.
The output without shift is as expected: }
The Problem
The output when holding shift is not.
The first time 3 is pressed while holding shift: #
Subsequent presses while still holding the same modifier: 3
Only 3 should be output by this mod morph when holding shift.
It doesn't matter how long you hold shift before the first press of the key. It is always #. All further presses are 3s (until you let go of the shift).
I raised this in the zmk discord in the help-forum and bravekarma was kind enough to attempt reproduction on what they said was basically zmkfirmware/main. They were not able to duplicate. only a 3 is output while holding shift.
The suggestion is that this might be fixed if the refil/zmk/adv360-z3 was brought up to match zmkfirmware/main.
The mod morph should not pass the modifiers on unless keep_mods is specified.
Mod Morphs in general are working. I guess the theory is that something has been fixed since refil/main was forked.
The text was updated successfully, but these errors were encountered: