-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node versions? #17
Comments
It wouldn't be hard to make this with the existing code, but do you have any specific use-case in mind? |
That data could be used for specific native modules builds for Electron (some V8 bindings could be deprecated or could break in minor versions of Node/Electron, for example |
https://github.com/electron/electron-rebuild already does that though? |
Not exactly that but kind of, yes. This just one of potential use-cases |
Hm, actually no. What I'm talking about is V8 API changes, electron-rebuild is project for electron apps but not for native modules. Native modules could be prebuilt to have binaries for different Electron versions. Use cases are different |
Hi, I'm the original author of electron-rebuild. While this initially seems like it'd be useful to avoid rebuilds, Electron is different enough in subtle dumb ways from node.js that binaries built against system node.js often don't work in Electron, even if NODE_MODULE_VERSION is identical :-/ So, until someone is actually gonna use this mapping in software, I'd just hold off on it, it's not as useful as one would think. |
This feature is obviously useful. Even if it is not related to electron-rebuild. Because this package is used in Browserslist, and people use See https://webpack.js.org/configuration/target#string, It provides |
It could be useful to have electron-to-nodejs versions also
The text was updated successfully, but these errors were encountered: