Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make easy edit from the web #40

Closed
Kikobeats opened this issue May 21, 2017 · 6 comments
Closed

Make easy edit from the web #40

Kikobeats opened this issue May 21, 2017 · 6 comments

Comments

@Kikobeats
Copy link
Owner

Kikobeats commented May 21, 2017

Because every section of the web is linked with a GitHub file, could be awesomeness link each section with a "Edit File" button for make easy contributions.

Related: docsifyjs/docsify#162

@Kikobeats
Copy link
Owner Author

Currently is possible do that (see the issue related)

@elrumordelaluz any design tip about how integrate this in the current UI? 😄

@elrumordelaluz
Copy link
Contributor

any design tip…

@Kikobeats you are thinking about something like a button "Edit ✏︎"? one per section or one generic?

@Kikobeats
Copy link
Owner Author

The button will be placed per each documentation section.

But I'm not sure about:

  • Where the button should be stay. top? bottom?
  • How the button should be looks.

I created edit-button branch for play with the code. This is how it looks right now:

screen shot 2017-06-05 at 11 03 54

@elrumordelaluz
Copy link
Contributor

elrumordelaluz commented Jun 5, 2017

I'd do something subtle like 👇
screen shot 2017-06-05 at 15 04 51

or more subtle like 👇
hover

Let me know if you want a PR

@Kikobeats
Copy link
Owner Author

I added a first iteration, thanks for the tips!

@elrumordelaluz
Copy link
Contributor

@Kikobeats nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants