Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing glslang-default-resource-limits to be static breaks shared library packaging #3316

Closed
rhabacker opened this issue Aug 23, 2023 · 0 comments · Fixed by #3317
Closed

Forcing glslang-default-resource-limits to be static breaks shared library packaging #3316

rhabacker opened this issue Aug 23, 2023 · 0 comments · Fixed by #3317

Comments

@rhabacker
Copy link
Contributor

The first commit of #2419 breaks packaging on openSUSE and may be other systems as documented at #3028 (comment)
@rhabacker rhabacker changed the title Forcing glslang-default-resource-limits to be static break shared library packaging Forcing glslang-default-resource-limits to be static breaks shared library packaging Aug 23, 2023
rhabacker added a commit to rhabacker/glslang that referenced this issue Aug 23, 2023
@rhabacker
Revert "CMake: Make glslang-default-resource-limits STATIC"
3c0a089 
Fixes KhronosGroup#3316

This reverts commit 6f22e41.
@rhabacker rhabacker mentioned this issue Aug 23, 2023
Merged
arcady-lunarg pushed a commit that referenced this issue Sep 5, 2023
@rhabacker @arcady-lunarg
Revert "CMake: Make glslang-default-resource-limits STATIC"
3787b69 
Fixes #3316

This reverts commit 6f22e41.
kd-11 pushed a commit to kd-11/glslang that referenced this issue Dec 11, 2023
@rhabacker @kd-11
Revert "CMake: Make glslang-default-resource-limits STATIC"
f121169 
Fixes KhronosGroup#3316

This reverts commit 6f22e41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "CMake: Make glslang-default-resource-limits STATIC" rhabacker/glslang
1 participant
@rhabacker