Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering points and line segments #917

Closed
peteroupc opened this issue Apr 16, 2017 · 7 comments
Closed

Rendering points and line segments #917

peteroupc opened this issue Apr 16, 2017 · 7 comments
Assignees

Comments

@peteroupc
Copy link

peteroupc commented Apr 16, 2017

The glTF 2.0 specification should include advice on rendering points and line segments (primitives with mode LINES, LINE_STRIP, LINE_LOOP, or POINTS), especially because the lighting calculations rely on vertex normals, which don't normally make much sense for line segments and points to have because they have no area. The specification should especially mention how the base color, emission, per-vertex colors, and other parameters affect how line segments and points are rendered.

@pjcozzi
Copy link
Member

pjcozzi commented Oct 19, 2017

Thanks for comment!

Discussed offline:

  • if normals are defined, use full PBR model
  • if normals are not defined, use full PBR model with the assumption that the line is lit from all directions

@emackey has volunteered to make the changed

@lexaknyazev
Copy link
Member

lexaknyazev commented Oct 24, 2017

@emackey While making those changes, please review existing impl. notes on attributes and lighting calculations (right before morph targets).

Also, spec should be more clear about:

  • Does TANGENT attribute always require NORMAL? (I assume yes.)
  • Is it OK to have POINTS with TANGENT?

@emackey
Copy link
Member

emackey commented Oct 26, 2017

Do we have any sample models that show points and lines?

@pjcozzi
Copy link
Member

pjcozzi commented Dec 24, 2017

@emackey did you make these spec updates?

@lexaknyazev
Copy link
Member

@pjcozzi @emackey
Any actions left?

@emackey
Copy link
Member

emackey commented Dec 5, 2018

I didn't make any updates myself, but I recall there were changes at some point to the relevant part of the spec for unrelated reasons. This is what it looks like now:

https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#point-and-line-materials

If that's OK with everyone, I vote we close this.

@peteroupc
Copy link
Author

I didn't make any updates myself, but I recall there were changes at some point to the relevant part of the spec for unrelated reasons. This is what it looks like now:

https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#point-and-line-materials

If that's OK with everyone, I vote we close this.

I have no objections with what that section currently says. Thus, this issue is closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants