-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Lights #137
Comments
Your observation does not seem wrong to me.
FYI: We'll add in the converter the possibility to override the defaults shaders and probably better built in lighting models (for convenience). |
Can we have working examples with light implemented in the scene itself? That would clear a lot of doubts. |
Is this duplicate with #93? |
Can we close this as duplicate with #93? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am trying to add a directional light through shader, using following logic:
vLighting = ambientLight + (directionalLightColor * max(dot(normal.xyz, directionalVector), 0.0))
There is a (0,0,1) plane in my geometry.
Although this plane receives the light, but the light effect is only visible when the camera is approaching normal of the surface. If the camera "look at" is parallel to plane then the plane gets darker.
Can you please suggest if I need to add more to the code?
The text was updated successfully, but these errors were encountered: