Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer: skeleton id management #51

Closed
julienduroure opened this issue Oct 18, 2018 · 2 comments
Closed

Importer: skeleton id management #51

julienduroure opened this issue Oct 18, 2018 · 2 comments
Assignees
@julienduroure
Labels
bug Something isn't working importer This involves or affects the import process

Comments

@julienduroure
Copy link
Collaborator

Currently, skeleton is added as root node, but seems it should not.
Have to read carefully the specification, and check what is done in samples / Setchfab models / polly project
@julienduroure julienduroure added bug Something isn't working importer This involves or affects the import process labels Oct 18, 2018
@julienduroure julienduroure self-assigned this Oct 18, 2018
@lexaknyazev
Copy link
Member

@julienduroure please don't rely heavily on the spec about skeleton.
It's still WIP, see KhronosGroup/glTF#1403, KhronosGroup/glTF#1270.

/cc @donmccurdy

@julienduroure
Copy link
Collaborator Author

Remove setting the new bone for now in d7f61b6
Seems it is OK in all samples and sketchfab checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienduroure julienduroure

Labels
bug Something isn't working importer This involves or affects the import process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienduroure @lexaknyazev