Skip to content

Commit

Permalink
Hide the model that has > 4 jointweights per vertex (#469)
Browse files Browse the repository at this point in the history
* Hide the model that has > 4 jointweights per vertex until the spec is clearer on this case

* Add a comment explaining why the >4 jointweight model was removed
  • Loading branch information
stevk authored Nov 14, 2018
1 parent 792cba3 commit 768254f
Show file tree
Hide file tree
Showing 9 changed files with 72 additions and 397 deletions.
Binary file removed Output/Animation_Skin/Animation_Skin_12.bin
Binary file not shown.
311 changes: 0 additions & 311 deletions Output/Animation_Skin/Animation_Skin_12.gltf

This file was deleted.

Binary file not shown.
Binary file not shown.
11 changes: 0 additions & 11 deletions Output/Animation_Skin/Manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,6 @@
1.0
]
}
},
{
"fileName": "Animation_Skin_12.gltf",
"sampleImageName": "Figures/SampleImages/Animation_Skin_12.png",
"camera": {
"translation": [
1.5,
0.0,
1.0
]
}
}
]
}
11 changes: 7 additions & 4 deletions Output/Animation_Skin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ skinA | skinB | skinC
:---: | :---: | :---:
<img src="Figures/skinA.png" height="60" width="100" align="middle"> | <img src="Figures/skinB.png" width="125" align="middle"> | <img src="Figures/skinC.png" width="100" align="middle">

skinD | skinE | skinF
:---: | :---: | :---:
<img src="Figures/skinD.png" width="144" align="middle"> | <img src="Figures/skinE.png" width="200" align="middle"> | <img src="Figures/skinF.png" width="135" align="middle">
skinD | skinE
:---: | :---:
<img src="Figures/skinD.png" width="144" align="middle"> | <img src="Figures/skinE.png" width="200" align="middle">

<!---skinD | skinE | skinF--->
<!---:---: | :---: | :---:--->
<!---<img src="Figures/skinD.png" width="144" align="middle"> | <img src="Figures/skinE.png" width="200" align="middle"> | <img src="Figures/skinF.png" width="135" align="middle">--->

The following table shows the properties that are set for a given model.

Expand All @@ -26,5 +30,4 @@ The following table shows the properties that are set for a given model.
| [09](Animation_Skin_09.gltf)<br>[View](https://bghgary.github.io/glTF-Assets-Viewer/?folder=2&model=9) | [<img src="Figures/Thumbnails/Animation_Skin_09.png" align="middle">](Figures/SampleImages/Animation_Skin_09.png) | `skinC` where all of the joints have a local rotation of -10 degrees, except the root which is rotated -90 degrees. |
| [10](Animation_Skin_10.gltf)<br>[View](https://bghgary.github.io/glTF-Assets-Viewer/?folder=2&model=10) | [<img src="Figures/Thumbnails/Animation_Skin_10.png" align="middle">](Figures/SampleImages/Animation_Skin_10.png) | `skinD` where each joint is animating with a rotation. There is a transform node in the joint hierarchy that is not a joint. That node has a mesh attached to it in order to show its location. |
| [11](Animation_Skin_11.gltf)<br>[View](https://bghgary.github.io/glTF-Assets-Viewer/?folder=2&model=11) | [<img src="Figures/Thumbnails/Animation_Skin_11.png" align="middle">](Figures/SampleImages/Animation_Skin_11.png) | `skinE`. |
| [12](Animation_Skin_12.gltf)<br>[View](https://bghgary.github.io/glTF-Assets-Viewer/?folder=2&model=12) | [<img src="Figures/Thumbnails/Animation_Skin_12.png" align="middle">](Figures/SampleImages/Animation_Skin_12.png) | `skinF`. |

11 changes: 0 additions & 11 deletions Output/Manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -297,17 +297,6 @@
1.0
]
}
},
{
"fileName": "Animation_Skin_12.gltf",
"sampleImageName": "Figures/SampleImages/Animation_Skin_12.png",
"camera": {
"translation": [
1.5,
0.0,
1.0
]
}
}
]
},
Expand Down
Loading

0 comments on commit 768254f

Please sign in to comment.