Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamVR: VK_EXT_acquire_xlib_display vkGetRandROutputDisplayEXT causes invalid VkDisplayKHR error #267

Closed
danginsburg opened this issue Aug 6, 2018 · 2 comments
Milestone

Comments

@danginsburg
Copy link

In SteamVR for direct mode we use VK_EXT_acquire_xlib_display. We get the following validation errors from object_tracker regarding VkDisplayKHR acquired from vkGetRandROutputDisplayEXT:

[ VUID-vkGetDisplayModePropertiesKHR-display-parameter ] Object: 0x157c570 (Type = 29) | Invalid DisplayKHR Object 0x157c570. The spec valid usage text states 'display must be a valid VkDisplayKHR handle' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/html/vkspec.html#VUID-vkGetDisplayModePropertiesKHR-display-parameter)

[ VUID-vkAcquireXlibDisplayEXT-display-parameter ] Object: 0x26d8570 (Type = 29) | Invalid DisplayKHR Object 0x26d8570. The spec valid usage text states 'display must be a valid VkDisplayKHR handle' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/html/vkspec.html#VUID-vkAcquireXlibDisplayEXT-display-parameter)" char*

[ VUID-vkRegisterDisplayEventEXT-display-parameter ] Object: 0x1766580 (Type = 29) | Invalid DisplayKHR Object 0x1766580. The spec valid usage text states 'display must be a valid VkDisplayKHR handle' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/html/vkspec.html#VUID-vkRegisterDisplayEventEXT-display-parameter)

The problem is that the codegen in object_tracker.cpp does not do CreateObject on the kVulkanObjectTypeDisplayKHR in vkGetRandROutputDisplayEXT so object_tracker is unaware of it. I tried modifying object_tracker_generator.py to consider it to have iscreate = True, but the problem is the generated code expect a pAllocator and there isn't one for this function. I figured I'd better pass it off to someone more familiar with the code.

@danginsburg
Copy link
Author

Confirmed fixed, closing.

@danginsburg
Copy link
Author

Sorry, wrong issue, reopening.

@danginsburg danginsburg reopened this Aug 7, 2018
@shannon-lunarg shannon-lunarg added this to the sdk-1.1.temp.0 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants