Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Unity 6 LTS URP #793

Open
4 of 7 tasks
nickhudson4 opened this issue Oct 27, 2024 · 1 comment
Open
4 of 7 tasks

Add support for Unity 6 LTS URP #793

nickhudson4 opened this issue Oct 27, 2024 · 1 comment

Comments

@nickhudson4
Copy link

nickhudson4 commented Oct 27, 2024

Describe the bug 💬

RoughRefractionFeature.cs appears to be broken in build for Unity 6 URP.

Steps to reproduce 🔢

  1. Reference the RoughRefreaction render feature in a URP pipeline asset.
  2. Build to Windows standalone
  3. Build logs will show error:
Cannot create required material because shader is null
ArgumentNullException: Value cannot be null.
Parameter name: material
  at UnityEngine.Rendering.CommandBuffer.DrawProcedural (UnityEngine.Matrix4x4 matrix, UnityEngine.Material material, System.Int32 shaderPass, UnityEngine.MeshTopology topology, System.Int32 vertexCount, System.Int32 instanceCount, UnityEngine.MaterialPropertyBlock properties) [0x0000c] in <acbc7a8432b24944a0e1db033a70c02a>:0 
  at UnityEngine.Rendering.Blitter.DrawTriangle (UnityEngine.Rendering.CommandBuffer cmd, UnityEngine.Material material, System.Int32 shaderPass, UnityEngine.MaterialPropertyBlock propertyBlock) [0x00024] in <830cbc5d3c4646578a140865867150d8>:0 
  at UnityEngine.Rendering.Blitter.DrawTriangle (UnityEngine.Rendering.CommandBuffer cmd, UnityEngine.Material material, System.Int32 shaderPass) [0x00000] in <830cbc5d3c4646578a140865867150d8>:0 
  at UnityEngine.Rendering.Blitter.BlitTexture (UnityEngine.Rendering.CommandBuffer cmd, UnityEngine.Rendering.RTHandle source, UnityEngine.Vector4 scaleBias, UnityEngine.Material material, System.Int32 pass) [0x00025] in <830cbc5d3c4646578a140865867150d8>:0 
  at UnityEngine.Rendering.Blitter.BlitTexture (UnityEngine.Rendering.RasterCommandBuffer cmd, UnityEngine.Rendering.RTHandle source, UnityEngine.Vector4 scaleBias, UnityEngine.Material material, System.Int32 pass) [0x00000] in <830cbc5d3c4646578a140865867150d8>:0 
  at UnityEngine.Rendering.Universal.Internal.CopyColorPass.ExecutePass (UnityEngine.Rendering.RasterCommandBuffer cmd, UnityEngine.Rendering.Universal.Internal.CopyColorPass+PassData passData, UnityEngine.Rendering.RTHandle source, System.Boolean useDrawProceduralBlit) [0x0009f] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.Internal.CopyColorPass.Execute (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.RenderingData& renderingData) [0x000d5] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityGLTF.RoughRefractionFeature+CustomRenderPass.Execute (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.RenderingData& renderingData) [0x00043] in <6ec77d07fb0749029423b4016916c776>:0 
  at UnityEngine.Rendering.Universal.ScriptableRenderer.ExecuteRenderPass (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.ScriptableRenderPass renderPass, UnityEngine.Rendering.Universal.UniversalCameraData cameraData, UnityEngine.Rendering.Universal.RenderingData& renderingData) [0x000b8] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.ScriptableRenderer.ExecuteBlock (System.Int32 blockIndex, UnityEngine.Rendering.Universal.ScriptableRenderer+RenderBlocks& renderBlocks, UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.RenderingData& renderingData, System.Boolean submit) [0x0003f] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.ScriptableRenderer.Execute (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.RenderingData& renderingData) [0x00331] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.UniversalRenderPipeline.RenderSingleCamera (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Rendering.Universal.UniversalCameraData cameraData) [0x0034a] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.UniversalRenderPipeline.RenderCameraStack (UnityEngine.Rendering.ScriptableRenderContext context, UnityEngine.Camera baseCamera) [0x003ca] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.Universal.UniversalRenderPipeline.Render (UnityEngine.Rendering.ScriptableRenderContext renderContext, System.Collections.Generic.List`1[T] cameras) [0x0007b] in <1d323b278df4437aa3676cfb1d572f9d>:0 
  at UnityEngine.Rendering.RenderPipeline.InternalRender (UnityEngine.Rendering.ScriptableRenderContext context, System.Collections.Generic.List`1[T] cameras) [0x0001c] in <acbc7a8432b24944a0e1db033a70c02a>:0 
  at UnityEngine.Rendering.RenderPipelineManager.DoRenderLoop_Internal (UnityEngine.Rendering.RenderPipelineAsset pipelineAsset, System.IntPtr loopPtr, UnityEngine.Object renderRequest) [0x0003c] in <acbc7a8432b24944a0e1db033a70c02a>:0 


Files to reproduce the issue ♻

No response

Editor Version 🎲

6000.0

Render Pipeline and version

17.0.3

UnityGLTF Version

2.14.0

Operating System 👩‍💻

Windows

When does this problem happen?

  • Editor Import
  • Runtime Import
  • Editor Export
  • Runtime Export

Additional Info 📜

No response

Validations 🩹

@hybridherbst
Copy link
Collaborator

Hi, yes, we're working on this. cc @pfcDorn

Please note that Unity 6 introduced a new Render Graph without any preparation time (it was simply introduced and is on by default for new projects in Unity 6). If you disable Render Graph, rough refraction still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants