Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 models should not have BINORMAL #174

Open
lasalvavida opened this issue Apr 9, 2018 · 2 comments
Open

2.0 models should not have BINORMAL #174

lasalvavida opened this issue Apr 9, 2018 · 2 comments
Labels

Comments

@lasalvavida
Copy link
Contributor

lasalvavida commented Apr 9, 2018

Currently we write out BINORMAL from COLLADA if it is present, but it is no longer a valid semantic in glTF 2.0 since it can be computed from TANGENT and NORMAL.

@javagl
Copy link
Contributor

javagl commented Apr 13, 2018

This probably refers to

if (colladaPrimitive->hasBinormalIndices()) {
?! (Just asking because it's still called BINORMAL there. But it might not matter, iff this case can simply be omitted...)

@lasalvavida
Copy link
Contributor Author

It is to be omitted, but thanks for the correction @javagl.

@lasalvavida lasalvavida changed the title 2.0 models should not have BITANGENT 2.0 models should not have BINORMAL Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants