From 62fbc1442cd4f98ac105f71cc34842bcc46e576b Mon Sep 17 00:00:00 2001 From: Popescu V <136721202+popescu-v@users.noreply.github.com> Date: Thu, 4 Jul 2024 17:36:02 +0200 Subject: [PATCH 1/3] Add `--allow-run-as-root` to OpenMPI command, according to upstream `khiops-env` closes #203 --- khiops/core/internals/runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/khiops/core/internals/runner.py b/khiops/core/internals/runner.py index 5fe03059..9700f78b 100644 --- a/khiops/core/internals/runner.py +++ b/khiops/core/internals/runner.py @@ -1269,7 +1269,7 @@ def _set_mpi_command_args_with_mpiexec(self, mpiexec_path, installation_method): elif platform.system() == "Linux": # For Linux native installations we use OpenMPI if installation_method == "binary+pip": - self.mpi_command_args.append("--quiet") + self.mpi_command_args += ["--allow-run-as-root", "--quiet"] self.mpi_command_args += [ "-n", str(self.max_cores), From 79940ca81861a6cc983c6679221b84827c056b19 Mon Sep 17 00:00:00 2001 From: Popescu V <136721202+popescu-v@users.noreply.github.com> Date: Thu, 4 Jul 2024 17:37:12 +0200 Subject: [PATCH 2/3] Remove variables for running OpenMPI as root in the CI Indeed, this is now hard-coded in the KhiopsLocalRunner, as per #203 --- .github/workflows/pip.yml | 3 --- .github/workflows/unit-tests.yml | 3 --- 2 files changed, 6 deletions(-) diff --git a/.github/workflows/pip.yml b/.github/workflows/pip.yml index ed05e318..093b4c06 100644 --- a/.github/workflows/pip.yml +++ b/.github/workflows/pip.yml @@ -71,9 +71,6 @@ jobs: - name: Run tests env: KHIOPS_SAMPLES_DIR: ${{ github.workspace }}/khiops-samples - # This is needed so that OpenMPI's mpiexec can be run as root - OMPI_ALLOW_RUN_AS_ROOT: 1 - OMPI_ALLOW_RUN_AS_ROOT_CONFIRM: 1 # Force > 2 CPU cores to launch mpiexec KHIOPS_PROC_NUMBER: 4 # Oversubscribe for MPI 4.x diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index bf7b9f45..a4341b25 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -91,9 +91,6 @@ jobs: KHIOPS_DOCKER_RUNNER_URL: https://localhost:11000 KHIOPS_DOCKER_RUNNER_SHARED_DIR: /tmp/sandbox KHIOPS_RUNNER_SERVICE_PATH: /scripts/run_service.sh - # This is needed so that OpenMPI's mpiexec can be run as root - OMPI_ALLOW_RUN_AS_ROOT: 1 - OMPI_ALLOW_RUN_AS_ROOT_CONFIRM: 1 # Force > 2 CPU cores to launch mpiexec KHIOPS_PROC_NUMBER: 4 # Oversubscribe for MPI 4.x From db36ba75a94101ebf9f8d90816fe85c11f8832ed Mon Sep 17 00:00:00 2001 From: popescu-v <136721202+popescu-v@users.noreply.github.com> Date: Thu, 4 Jul 2024 18:43:15 +0200 Subject: [PATCH 3/3] Update CHANGELOG for release 10.2.2.1 (#206) --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ef1f42bf..650f4966 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,12 @@ - Example: 10.2.1.4 is the 5th version that supports khiops 10.2.1. - Internals: Changes in *Internals* sections are unlikely to be of interest for data scientists. +## 10.2.2.1 - 2024-07-05 + +### Changed +- *Internals*: + - The OpenMPI backend now executes with the `--allow-run-as-root` option. + ## 10.2.2.0 - 2024-07-03 ### Added