From faf05a664b86702b0add060e5cf6cdd8e61238a0 Mon Sep 17 00:00:00 2001
From: Kevin Barabash <kevinb@khanacademy.org>
Date: Wed, 15 Feb 2023 11:37:29 -0500
Subject: [PATCH] remove watch:types, people can use 'yarn typecheck --watch',
 update CI to delete .d.ts files for tests

---
 .github/workflows/node-ci.yml | 6 +++++-
 package.json                  | 1 -
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/node-ci.yml b/.github/workflows/node-ci.yml
index f8138cb1..7d3d411a 100644
--- a/.github/workflows/node-ci.yml
+++ b/.github/workflows/node-ci.yml
@@ -73,7 +73,11 @@ jobs:
       run: yarn build
 
     - name: Build Types
-      run: yarn build:types && rm -rf packages/*/dist/**/__types__
+      # There isn't an easy way for us to type check our tests without
+      # also including them in dist folder when we build the .d.ts files
+      # so we have to manually remove them.
+      # TODO(kevin): Figure out how to have the `build:types` script do this.
+      run: yarn build:types && rm -rf packages/*/dist/**/__tests__
 
     # Linting / type checking
     - name: Eslint
diff --git a/package.json b/package.json
index f21d0232..88dda299 100644
--- a/package.json
+++ b/package.json
@@ -75,7 +75,6 @@
     "build:prodsizecheck": "rollup -c build-settings/rollup.config.js --configPlatforms='browser' --configFormats='esm' --configEnvironment='production'",
     "build:types": "yarn tsc --build --verbose tsconfig-build.json",
     "watch": "rollup -c build-settings/rollup.config.js --watch",
-    "watch:types": "yarn build:types --watch",
     "clean": "rm -rf packages/wonder-stuff-*/dist && rm -rf packages/wonder-stuff-*/node_modules && rm -f packages/*/tsconfig.tsbuildinfo",
     "coverage": "yarn run jest --coverage",
     "format": "prettier --write .",