From dd0682c1ece3677dfaa0dba65c234694198e0fb8 Mon Sep 17 00:00:00 2001 From: Kevin Barabash Date: Tue, 21 Feb 2023 14:40:11 -0500 Subject: [PATCH] Make core a real dep of server (#544) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary: When reviewing the changes in #536, I noticed that some packages were being bumped a major version even though none of the changeset .md files specified such changes. It appears this is happening due changeset treating peer deps differently from regular deps. This PR fixes the issue by make wonder-stuff-core a regular dependency of wonder-stuff-server. Issue: None ## Test plan: - land this PR and see #536 update appropriately Author: kevinbarabash Reviewers: jeresig, #frontend-infra, #typescript, somewhatabstract Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Analyze (javascript), ✅ gerald, ⏭ dependabot Pull Request URL: https://github.com/Khan/wonder-stuff/pull/544 --- .changeset/beige-otters-exist.md | 5 +++++ packages/wonder-stuff-server/package.json | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/beige-otters-exist.md diff --git a/.changeset/beige-otters-exist.md b/.changeset/beige-otters-exist.md new file mode 100644 index 00000000..501ecd8b --- /dev/null +++ b/.changeset/beige-otters-exist.md @@ -0,0 +1,5 @@ +--- +"@khanacademy/wonder-stuff-server": patch +--- + +Make wonder-stuff-core a real dependency instead of a peer dependency diff --git a/packages/wonder-stuff-server/package.json b/packages/wonder-stuff-server/package.json index b9b7342a..4bf29300 100644 --- a/packages/wonder-stuff-server/package.json +++ b/packages/wonder-stuff-server/package.json @@ -14,13 +14,15 @@ "scripts": { "test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'" }, + "dependencies": { + "@khanacademy/wonder-stuff-core": "^1.0.2" + }, "devDependencies": { "ws-dev-build-settings": "^0.0.5" }, "author": "", "license": "MIT", "peerDependencies": { - "@khanacademy/wonder-stuff-core": "^1.0.2", "express": "^4.17.2", "express-winston": "^4.2.0", "winston": "^3.4.0"