From 9f08a553b5c3922325ed2c460e47c3f7427ef5b5 Mon Sep 17 00:00:00 2001 From: Jeff Yates Date: Fri, 12 Jul 2024 12:54:14 -0500 Subject: [PATCH] =?UTF-8?q?[=F0=9F=94=A5AUDIT=F0=9F=94=A5]=20[ignoretsxtes?= =?UTF-8?q?tfiles]=20Ignore=20tsx=20test=20files=20in=20changeset=20check?= =?UTF-8?q?=20(#2270)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🖍 _This is an audit!_ 🖍 ## Summary: This means we can edit tsx test files without being asked to add per package changesets. Issue: XXX-XXXX ## Test plan: Edit a tsx test file and push to a branch, raise a PR and see that changeset check does not ask for a changeset. Author: somewhatabstract Auditors: jeresig Required Reviewers: Approved By: jeresig Checks: ⌛ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⌛ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ⌛ Publish npm snapshot (ubuntu-latest, 20.x), ⏭️ dependabot, ⌛ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: https://github.com/Khan/wonder-blocks/pull/2270 --- .github/workflows/node-ci-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node-ci-pr.yml b/.github/workflows/node-ci-pr.yml index af4fb92ee..db262aa33 100644 --- a/.github/workflows/node-ci-pr.yml +++ b/.github/workflows/node-ci-pr.yml @@ -53,7 +53,7 @@ jobs: with: changed-files: ${{ steps.changed.outputs.files }} files: packages/ # Only look for changes in packages - globs: "!(**/__tests__/**), !(**/dist/*), !(**/*.test.ts)" # Ignore test files + globs: "!(**/__tests__/**), !(**/dist/*), !(**/*.test.{ts,tsx})" # Ignore test files matchAllGlobs: true # All globs must match (disjunction is the default) conjunctive: true # Only return files that match all of the above