From 3c1682f3b56f4478d5fe6b9d04f30db6ac6595ca Mon Sep 17 00:00:00 2001 From: Jeremy Wiebe Date: Mon, 16 Dec 2024 10:45:04 -0800 Subject: [PATCH] QoL: Turn on automatic commit of changesets (#2394) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary: The `changesets` tooling supports a configuration option that causes `yarn changeset` to automatically add and commit the created file ([docs](https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#commit-boolean-or-module-path-as-a-string-or-a-tuple-like-modulepath-string-options-any)). NOTE: If there are existing changes in your local repo, these changes _will not_ be included in the commit (so it's safe to run `yarn changeset` no matter the state of your repo). There are PRs in other Khan Academy repos that use the Changesets tooling. We'll only land this if there's consensus across these other repos too: * https://github.com/Khan/wonder-stuff/pull/1097 * https://github.com/Khan/wonder-blocks/pull/2394 (this PR) * https://github.com/Khan/perseus/pull/2008 Issue: "none" ## Test plan: `yarn changeset` Fill in the details Once complete, run `git log` and you will see that the changeset entry you created has been added and committed to git - all that's left is to create the PR! Author: jeremywiebe Reviewers: jandrade, somewhatabstract Required Reviewers: Approved By: jandrade Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ gerald, ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⌛ undefined Pull Request URL: https://github.com/Khan/wonder-blocks/pull/2394 --- .changeset/config.json | 4 ++-- .changeset/eighty-mayflies-refuse.md | 2 ++ .../src/components/__tests__/single-select.test.tsx | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changeset/eighty-mayflies-refuse.md diff --git a/.changeset/config.json b/.changeset/config.json index 84cadc423..5ade926a5 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -1,7 +1,7 @@ { "$schema": "https://unpkg.com/@changesets/config@1.6.2/schema.json", "changelog": "@changesets/cli/changelog", - "commit": false, + "commit": true, "linked": [], "access": "public", "baseBranch": "main", @@ -10,4 +10,4 @@ "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": { "updateInternalDependents": "always" } -} \ No newline at end of file +} diff --git a/.changeset/eighty-mayflies-refuse.md b/.changeset/eighty-mayflies-refuse.md new file mode 100644 index 000000000..a845151cc --- /dev/null +++ b/.changeset/eighty-mayflies-refuse.md @@ -0,0 +1,2 @@ +--- +--- diff --git a/packages/wonder-blocks-dropdown/src/components/__tests__/single-select.test.tsx b/packages/wonder-blocks-dropdown/src/components/__tests__/single-select.test.tsx index cd0ced15b..a622a3202 100644 --- a/packages/wonder-blocks-dropdown/src/components/__tests__/single-select.test.tsx +++ b/packages/wonder-blocks-dropdown/src/components/__tests__/single-select.test.tsx @@ -138,6 +138,7 @@ describe("SingleSelect", () => { // Assert expect(opener).toHaveTextContent("Plain Toggle A"); }); + it("can render a Node as a label", async () => { // Arrange doRender(